search

pradel / react-responsive-modal

Simple responsive react modal
https://react-responsive-modal.leopradel.com/
MIT License
604 stars 95 forks source link

feat: ability to specify id for container #489

Closed cyntler closed 2 years ago

cyntler commented 2 years ago

Hey @pradel! 👋 Please do a code review if you can ;)

Closes #483

codecov[bot] commented 2 years ago

Codecov Report

Merging #489 (c32ef80) into master (dcc0c74) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   95.26%   95.28%   +0.02%     
==========================================
  Files           6        6              
  Lines         190      191       +1     
  Branches       69       69              
==========================================
+ Hits          181      182       +1     
  Misses          9        9
Impacted Files Coverage Δ
react-responsive-modal/src/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dcc0c74...c32ef80. Read the comment docs.

pradel commented 2 years ago

Thanks!