search

pradel / react-responsive-modal

Simple responsive react modal
https://react-responsive-modal.leopradel.com/
MIT License
604 stars 95 forks source link

feat: support for React 18 #498

Closed huksley closed 1 year ago

huksley commented 1 year ago

Adds react 18 to peer dependencies

huksley commented 1 year ago

Published as @huksley/react-responsive-modal@6.3.3

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.28% // Head: 95.28% // No change to project coverage :thumbsup:

Coverage data is based on head (a1222a0) compared to base (ee57745). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #498 +/- ## ======================================= Coverage 95.28% 95.28% ======================================= Files 6 6 Lines 191 191 Branches 69 69 ======================================= Hits 182 182 Misses 9 9 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=L%C3%A9o+Pradel). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=L%C3%A9o+Pradel)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Maciej916 commented 1 year ago

I installed @huksley/react-responsive-modal@6.3.3 and it seems like flicker effect still exist, i don't know if it is only for me because im using nextjs

huksley commented 1 year ago

I haven't fixed the flicker in this PR.

In my code which uses react-responsive-modal I am doing this fix https://github.com/pradel/react-responsive-modal/issues/495#issuecomment-1174789792

Maciej916 commented 1 year ago

I haven't fixed the flicker in this PR.

In my code which uses react-responsive-modal I am doing this fix #495 (comment)

I thought you implemented this because of your comment but it, my mistake, but it would be good if this is implemented in the release so there is no need to repeat this code each modal.

huksley commented 1 year ago

Added feature request into Bedrock project https://github.com/Bedrock-Layouts/Bedrock/issues/1355

huksley commented 1 year ago

It seems that React 18 support fixed in 1.3.1 of @bedrock-layout/use-forwarded-ref

ashtonpaul commented 1 year ago

@pradel Anything preventing this from being merged upstream to npm? Thanks in advance.

ArturoDucasse commented 1 year ago

Any updates on this PR? @pradel

pradel commented 1 year ago

Published in 6.4.1, thanks for the pr!