Open pikaju opened 1 year ago
Thanks for the pr! Could you please add an example in the docs so I can try it?
Patch coverage: 100.00
% and project coverage change: +0.16
:tada:
Comparison is base (
16aad65
) 95.28% compared to head (d2c9bb4
) 95.45%.:exclamation: Current head d2c9bb4 differs from pull request most recent head 11fd42a. Consider uploading reports for the commit 11fd42a to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hey @pradel, thanks for the response. I added an example and docs in the Next project.
I also changed how modals are centered, from the "inline" behavior to flex-box centering. I did this because there was an issue when the modal had little space (e.g. on a mobile device) and the pseudo-element you had before was wrapped to a new line. This implementation doesn't do that.
@pikaju could you please split the pr into two parts?
@pradel Sorry, but that doesn't seem worth the effort, I suggest just releasing a new major version
Adds option that keeps the Modal mounted even when it is hidden. This is useful for keeping the DOM state inside the Modal as well as for SEO purposes.
Fixes #233 and #495