search

pradoslaw / coyote

4programmers.net
https://4programmers.net
MIT License
115 stars 30 forks source link

styling table in dark mode #756

Closed goldipl closed 6 months ago

danon commented 6 months ago

@goldipl Please add the ruleset in _dark_markdown.scss.

goldipl commented 6 months ago

@danon Done :)

danon commented 6 months ago

Borders are still not correct.

table td in _tables.scss has hardcoded color. Override border-top-color with #2f2f2f in _dark_markdown.scss. And th probably as well.

goldipl commented 6 months ago

Table borders colors changed to: #2f2f2f

danon commented 6 months ago

@goldipl Please, don't use !important.

danon commented 6 months ago

Can you revert your changes from _dark_topic.scss, now that there are no changes there?

goldipl commented 6 months ago

@danon Done :)

danon commented 6 months ago

@goldipl The change is deployed to https://4programmers.dev/.

It's an opporutnity to check if the desired behaviour is reproduced, as well as check for regression of existing tables, for example in wiki.

danon commented 6 months ago

The change is deployed to production.