search

pradoslaw / coyote

4programmers.net
https://4programmers.net
MIT License
115 stars 30 forks source link

fix msg notification img max-height #759

Closed goldipl closed 6 months ago

goldipl commented 6 months ago

fixing notification image max-height to 35px & centering img Screenshot below:

fiximg

danon commented 6 months ago

mw-100 is "width 100%" in bootstrap. Why would it set max-height as well?

Please add dedicated class, like user-avatar, and use that to set max-height.

https://github.com/pradoslaw/coyote/issues/720

goldipl commented 6 months ago

@danon Done :)

goldipl commented 6 months ago

@danon master merged into my branch

danon commented 6 months ago

@danon master merged into my branch

Commit: https://github.com/pradoslaw/coyote/pull/759/commits/168c0150a674d4b60b4111671d501030d38ebedc that is now merged was removed from master, we don't want it.

Can you reapply your changes onto the newest master?

goldipl commented 6 months ago

ok, so I will close this PR and I will make a one new

danon commented 6 months ago

@goldipl You don't have to do that, you can just push force your branch.

With a new PR we lose this history, conversation and context. Let's continue this PR.