pradyunsg / furo

A clean customizable documentation theme for Sphinx
https://pradyunsg.me/furo/quickstart
MIT License
2.76k stars 317 forks source link

Add accessible name to 'Edit this page' icon #411

Closed hugovk closed 2 years ago

hugovk commented 2 years ago

Running Lighthouse on https://pillow.readthedocs.io/en/latest/ gives a good accessibility score with one suggestion:

image

For the edit icon:

Link text (and alternate text for images, when used as links) that is discernible, unique, and focusable improves the navigation experience for screen reader users. Learn more.

Here's a suggestion, following https://kittygiraudel.com/2020/12/10/accessible-icon-links/

hugovk commented 2 years ago

Oops, that's the second time I've done a "review" instead of committing files from a batch! Let's try again...

hugovk commented 2 years ago

You're welcome!

We're trying out Furo for the Pillow docs, currently main is using it at https://pillow.readthedocs.io/en/latest/ and if all is well the next quarterly release will put it at the default https://pillow.readthedocs.io/en/stable/