search

pradyunsg / furo

A clean customizable documentation theme for Sphinx
https://pradyunsg.me/furo/quickstart
MIT License
2.76k stars 317 forks source link

Increase icon sizes #554

Closed BobDotCom closed 1 year ago

BobDotCom commented 2 years ago

Description

This PR increases the size of some icons in order to improve accessibility, particularly for mobile devices. The larger sizes only consume a slightly larger horizontal width, while the vertical width is mainly unchanged due to padding/margin - which is great, because it only takes up previously empty space. I've included some before/after comparison images below.

Rationale

I've found that on mobile the menu icons are harder to tap than they should be, and compared to honestly most other websites the proportions just look and feel unnatural. I've even had difficulty clicking the icons on desktop sometimes. These new sizes make the site feel more modern and easy to use.

Mobile

 ### Header - Before Screen Shot 2022-10-15 at 7 52 55 PM - After Screen Shot 2022-10-15 at 7 53 24 PM ### Footer - Before Screen Shot 2022-10-15 at 7 54 10 PM - After Screen Shot 2022-10-15 at 7 54 57 PM

Desktop

 ### Header (Wide) - Before Screen Shot 2022-10-15 at 6 43 04 PM - After Screen Shot 2022-10-15 at 6 44 14 PM ### Header (Narrow) - Before Screen Shot 2022-10-15 at 7 49 53 PM - After Screen Shot 2022-10-15 at 7 50 23 PM ### Footer - Before Screen Shot 2022-10-15 at 6 45 57 PM - After Screen Shot 2022-10-15 at 6 46 26 PM
BobDotCom commented 1 year ago

@pradyunsg any feedback on this and #555?

BobDotCom commented 1 year ago

@pradyunsg please let me know if you plan on merging this and #555. These PRs include features that I use on my own documentation (https://docs.pycord.dev) and I've made a temporary fork to currently apply the changes, but need to know if I should plan on making a permanent fork of furo or if these improvements will be merged here.

Thanks, BobDotCom

pradyunsg commented 1 year ago

Let's do this. :)