pradyuprasad / pe

0 stars 0 forks source link

Name does not allow hyphens #7

Open pradyuprasad opened 5 days ago

pradyuprasad commented 5 days ago

Many people have hyphens in their name, and so it is expected that an application which tracks students should allow hyphens. However, the add command does not allow hyphens

Steps to reproduce

  1. Ensure there is no user called Ben-Lim in the app. If there is you can replace with any user with hyphens
  2. add n/Ben-Lim p/98765432 e/ben@example.com a/John street, block 123, #01-01 f/100
  3. This command will fail to execute. Screenshot is attached below

image.png

nus-se-bot commented 1 day ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

The team agrees that hyphens are a possible occurrence in students' names. However, this would be a feature flaw rather than a functionality bug, as we have stated the validation within the command format (as seen in the screenshot above).

We believe that this warrants a low-severity than medium-severity functionality bug: there is no need for teachers to represent the legal names of their students, character-by-character, in EduLog. Instead, it is for tracking and identification purposes. We hence think that the entry of the student without the hyphen, e.g. Ben Lim, would not significantly diminish the tutor's ability to identify students based on our list. Hence, the inconvenience would be low and rare in the team's opinion.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your reason]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]