search

praeclarum / FuGetGallery

An alternative web UI for browsing nuget packages
https://www.fuget.org
MIT License
683 stars 121 forks source link

Add explicit Mono.Cecil dependency #103

Closed MaceWindu closed 4 years ago

MaceWindu commented 4 years ago

Right now it use 0.10 dependency from ICSharpCode.Decompiler, which fails on some assemblies. E.g. https://www.fuget.org/packages/Oracle.ManagedDataAccess

praeclarum commented 4 years ago

Oh yeah I guess that version is pretty old now. But I’m surprised the decompiler can work with the Cecil API change. Shouldn’t we bump the decompiler’s version too? Or am I worried about nothing?

MaceWindu commented 4 years ago

I used this approach, because it required less changes for quick fix (I use this change for several mothes already locally and didn't see any issues yet).

Updating decompiler itself will require more changes, but agree that it should be done too.

MaceWindu commented 4 years ago

I've looked into updating decompiler itself, but they removed cecil in versions 4+, so it's quite a big change. I will try to migrate it, but it could take some time so maybe it makes sense to merge this in meantime

praeclarum commented 4 years ago

Ahhh, right I forgot they switched. Great :-/ Don't start that work. Let me have a look first and decide what to do.

OK, I'll probably merge this in then.

MaceWindu commented 4 years ago

Yeah, tried to do it today, but it's basically require full rewrite of reflection-related stuff. Not sure I have time for that in near future.