search

praeclarum / FuGetGallery

An alternative web UI for browsing nuget packages
https://www.fuget.org
MIT License
683 stars 121 forks source link

Frameworks links don't work on the main page of a package #84

Open svick opened 4 years ago

svick commented 4 years ago

When you go to e.g. https://www.fuget.org/packages/Microsoft.Bcl.AsyncInterfaces/1.0.0, all the Frameworks links (i.e. net461 and netstandard2.0) don't do anything: they link back to the same page.

If you go to a subpage for the package (e.g. https://www.fuget.org/packages/Microsoft.Bcl.AsyncInterfaces/1.0.0/lib/netstandard2.1/Microsoft.Bcl.AsyncInterfaces.dll), then the links start to work.

OskarKlintrot commented 4 years ago

The bug is in this method: https://github.com/praeclarum/FuGetGallery/blob/c9e7aec5df7a07b20e6168f3ba9994abb22a42a6/Pages/packages/details.cshtml#L113-L150

I tried to give it a go but there is a lot going on and the method already contains a bodge to fix another, similar, issue (lines 118-119) and there is no tests so IMHO the way forward would be to rewrite that method but that is not a simple task. Give it a go if you like ;)