search

praeclarum / FuGetGallery

An alternative web UI for browsing nuget packages
https://www.fuget.org
MIT License
683 stars 121 forks source link

Target .NET Core 3.1 #90

Closed bgrainger closed 3 years ago

bgrainger commented 4 years ago

I'm not sure what your plans for targeting newer versions of .NET Core are, and although I could have opened an issue to discuss first, I was going to do this work anyway, so I thought I'd simply share the code as a PR to start the discussion.

Targetting .NET Core 3.1 will allow newer C# language versions to be used more easily and will use the latest runtime and performance improvements in .NET Core 3.1. It's also an LTS release.

Ported following the instructions at https://docs.microsoft.com/en-us/aspnet/core/migration/22-to-30.

OskarKlintrot commented 4 years ago

3.1 has shipped now ;)

Is Newtonsoft really necessary to add now that System.Text.Json exists?

bgrainger commented 4 years ago

Updated to .NET Core 3.1.

praeclarum commented 4 years ago

I'm not sure if I need to change any Azure settings so will wait to the evening to merge.

bgrainger commented 4 years ago

Rebased to fix conflicts.

bgrainger commented 4 years ago

Rebased (again) to fix conflicts.

praeclarum commented 3 years ago

I'll be accepting you .NET 5.0 PR instead. Thanks as always!