search

praekelt / go-jsbox-location

Location finder for go-jsbox
Other
2 stars 0 forks source link

testing fixtures #10

Closed rudigiesler closed 10 years ago

rudigiesler commented 10 years ago

Need to create a system where the users can add data to a fixture that can be used in the testing of their app.

rudigiesler commented 10 years ago

@justinvdm ready for preliminary review. Let me know if you think that there's a different or better way of doing this.

justinvdm commented 10 years ago

Other than the two comments, general approach looks good :) Let me know what you think. Will do a more thorough review once those are resolved.

justinvdm commented 10 years ago

Minor comments, looks awesome :)

rudigiesler commented 10 years ago

@justinvdm fixed issues and pushed. If you can have another look and see if everything is okay.

justinvdm commented 10 years ago

:+1:

justinvdm commented 10 years ago

:cake: