search

praekelt / go-jsbox-location

Location finder for go-jsbox
Other
2 stars 0 forks source link

Add OpenStreetMap lookups #17

Closed gsvr closed 9 years ago

hodgestar commented 9 years ago

This would be awesome.

gsvr commented 9 years ago

@imsickofmaps Please do a preliminary review. I think I should still add more tests that check the different opts choices.

hodgestar commented 9 years ago

Very high-level comment -- I think having splitting out helpers for Google Maps and Openstreet Map and then just setting a self.map_api instance on the LocationState would make the implementation a lot cleaner?

imsickofmaps commented 9 years ago

@hodgestar LOL! We just had this exact conversation in the office... :)

hodgestar commented 9 years ago

:D

hodgestar commented 9 years ago

Superseded by #23 and #24.