search

praekelt / go-jsbox-location

Location finder for go-jsbox
Other
2 stars 0 forks source link

Add support for Open Street Map to the fixture creation in lib/testing #23

Closed hodgestar closed 9 years ago

hodgestar commented 9 years ago

Currently it only supports GoogleMaps.

Likely we'll want to restructure this.

hodgestar commented 9 years ago

Ready for review.

imsickofmaps commented 9 years ago

@hodgestar are you reviewing this internally or want us to make a pass too?

hodgestar commented 9 years ago

@imsickofmaps If you have time to do a pass over it, that would be awesome. If not, I'll find someone on the Vumi team to review it.

imsickofmaps commented 9 years ago

@hodgestar I'm just dealing with some operational issues on NDOH, so if an internal person can that would be quicker

justinvdm commented 9 years ago

@hodgestar @imsickofmaps sorry for the delay, taking a look.

justinvdm commented 9 years ago

Left some minor comments, but I'm :+1: on this landing now if it is needed. We should also update the tests of apps using the fixture helper.

hodgestar commented 9 years ago

My plan for other apps is to land #24 and any other things we need to get the structure of this right and then do a new release (0.2.0) and update the dependant apps.

justinvdm commented 9 years ago

+1 on the plan.

hodgestar commented 9 years ago

@justinvdm Ready for re-review.

justinvdm commented 9 years ago

:+1: when Travis is happy.