Feature/25 add skip option to location state

praekelt / go-jsbox-location

Location finder for go-jsbox

Other

2 stars 0 forks source link

Feature/25 add skip option to location state #33

Closed codiebeulaine closed 8 years ago

codiebeulaine commented 8 years ago

@hodgestar ready for help :)

hodgestar commented 8 years ago

It looks like the two tests that are failing are just failing because with 's. Skip' added, the way the results are paginated changes. Following the making-skip_text-null-by-default suggestion should fix all the existing tests and then we can add new tests for when the skipping option is displayed.

hodgestar commented 8 years ago

Looking really good otherwise.

codiebeulaine commented 8 years ago

@hodgestar changed some stuff but getting new errors from the example folder?