praekelt / go-proto-fsm

Prototype of a new Vumi Go campaign manager UI (also known as the spaghetti monster).
0 stars 0 forks source link

Add edit icon to action toolbar #36

Closed badlard closed 10 years ago

badlard commented 10 years ago

The action toolbar should include an 'edit' icon.

Clicking on the edit button enables the user to change the original values they inputted when creating the item.

screen shot 2014-09-18 at 1 44 31 pm

justinvdm commented 10 years ago

@andreit Left some questions.

I'm surprised by how much complexity this PR added and I don't think we are covering most of those cases in tests. We seem to have tests for editing each component's name, but I don't think we are covering things like adding new endpoints, renaming endpoints, and quite a few other things.

justinvdm commented 10 years ago

@andreit can we merge in develop to get travis happy again?

:+1: once travis is happy.