Add Controllers - Githubissues

praekelt / mama-ng-scheduler

A re-usable scheduler for MAMA Nigeria.

MIT License

0 stars 0 forks source link

Add Controllers #13

Closed LyndsayLawrence closed 9 years ago

LyndsayLawrence commented 9 years ago

Ready for review

hodgestar commented 9 years ago

Generally looks good. Questions:

Could you tell me why the views files are being deleted (especially the error page one). I'm guessing this is just me being a Grail noob.
Can we have some tests?

LyndsayLawrence commented 9 years ago

We do not require the views, because this is a pure JSON RESTful API, it has no ui.

Tests for the controllers are API tests (I did it through Chrome's POSTman), not sure how I would automate them. I will see what I can do.

LyndsayLawrence commented 9 years ago

Ready for re-review

hodgestar commented 9 years ago

Left one small comment. Once that's addressed I'm happy for this to land, but we should definitely open an issue for adding unit tests for all the controllers.

hodgestar commented 9 years ago

:+1: