search

praekelt / vumi-bot

Simple bot that performs various actions.
0 stars 0 forks source link

Feature/issue 12 jids as filenames #13

Closed smn closed 12 years ago

smn commented 12 years ago

JIDs are making publishing data as a Gist very unhappy. This fixes that.

hodgestar commented 12 years ago

Looks good.

jerith commented 12 years ago

I'd prefer to strip off the resource from the JID rather than use it as part of the filename. Since some clients randomly generate part of the resource, we'll probably end up with a lot of cruft. (Although there's something to be said for a more general solution to the identity problem...)

smn commented 12 years ago

I'd prefer the general solution but that's beyond the scope of this ticket.

------Original Message------ From: Jeremy Thurgood To: Simon de Haan Subject: Re: [vumi-bot] Feature/issue 12 jids as filenames (#13) Sent: Feb 27, 2012 23:40

I'd prefer to strip off the resource from the JID rather than use it as part of the filename. Since some clients randomly generate part of the resource, we'll probably end up with a lot of cruft. (Although there's something to be said for a more general solution to the identity problem...)

Reply to this email directly or view it on GitHub: https://github.com/praekelt/vumi-bot/pull/13#issuecomment-4203748

Sent via my mobile device.

jerith commented 12 years ago

Oh, yes. Sorry, I meant that as a thing to think about later, not an objection to landing this branch.

:+1: