Busy message locking - Githubissues

projectmushroom commented 7 years ago

Lock message whilst it's being worked on
10 second message refresh
5 minute message locking
Alert message when actioned before poll interval
Message lock triggered when opening the following modals: Reply, Bulk Reply, Forward, Open Case
Messages unlocked when dismissing modal

justinvdm commented 7 years ago

My lack of context on this might mean these things are actually not important, but some things I'm wondering:

we obviously want other clients to notice that a message is locked as soon as possible, but to do that, we appear to be hitting the api every 10s per client (so potentially quite frequent hits if there are many UI users), and doing a query which I think involves a few joins on potentially large table. I'm wondering if we'll be running into performance issues because of this. I could be overthinking this though. @miltontony considering your context on this project and experience with postgres, what are your thoughts?
what happens if another client locks an already locked message since a new poll has not yet happened? Would it just mean the locking mechanism doesn't hold here? If that is negligible, maybe thit is okay. If not, maybe we should do something like reject the api call and provide relevant feedback in the UI that the message is locked?

justinvdm commented 7 years ago

@projectmushroom @erikh360 left comments, looks good :)

sorry for the spam amount of irrelevant questions, I think I'm lacking some understanding general casepro concepts.

projectmushroom commented 7 years ago

@justinvdm Thanks for the review, I've made the necessary changes

praekeltfoundation / casepro