search

praekeltfoundation / diamondash

Dashboard for how we use Graphite
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

Fix weird 'empty' response for dynamic widgets #119

Closed justinvdm closed 10 years ago

justinvdm commented 10 years ago

Dynamic widgets snapshot responses are {} when their backend gives a bad response. We should remove this handling, and instead just rely on the 'catch-all' done for all api requests (so the client gets a 500 for the api request).

justinvdm commented 10 years ago

Ready for review (its pretty small).

hodgestar commented 10 years ago

:+1:

justinvdm commented 10 years ago

Wow, thanks for the amazingly fast review :)

On 5 February 2014 09:21, Simon Cross notifications@github.com wrote:

[image: :+1:]

Reply to this email directly or view it on GitHubhttps://github.com/praekelt/diamondash/pull/119#issuecomment-34142968 .