search

praekeltfoundation / diamondash

Dashboard for how we use Graphite
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

More dynamic chart dimensions #130

Closed justinvdm closed 10 years ago

justinvdm commented 10 years ago

Charts have a ChartDimensions structure for separating how the chart's dimensions are calculated from the actual rendering (avoids littering the view with dimension calculations).

At the moment, we recompute all the charts properties when we do a ChartDimensions.prototype.set. This will complicate things when we have charts that need their dimensions calculated differently (like pie charts). The plan is to change dimension properties to be computed when accessed, instead of trying to recompute all the properties at once whenever we do a set.

justinvdm commented 10 years ago

Ready for review.

hodgestar commented 10 years ago

:+1: