search

praekeltfoundation / go-jsbox-skeleton

Skeleton for a vumi javascript sandbox app
BSD 3-Clause "New" or "Revised" License
1 stars 12 forks source link

End state test fails #2

Closed imsickofmaps closed 10 years ago

imsickofmaps commented 10 years ago

https://github.com/praekelt/go-jsbox-skeleton/blob/develop/test/app.test.js#L64

Maybe some behaviour changes upstream mean: state: 'states:start'should be: state: 'states:end'

justinvdm commented 10 years ago

Thanks, its exactly what you thought, we now don't expect end states to fast forward the user to their next state once they have been displayed. We went back to the way things were, where the user stays on the end state, then on a new session, transitions to the next state (like the other states).

Fixing now.

justinvdm commented 10 years ago

Ready for review, sorry about this.

imsickofmaps commented 10 years ago

:+1: thanks