Total users metrics shouldn't be separated into weeks for USSD app

[justinvdm]

It looks like the ghr ussd js app is separating the metrics fired for users into weeks (the metric looks something like ghr_ussd_total_users_<week>). I think this needs to be changed to simply increment the total users (so the name should like something like ghr_ussd_total_users). The app does not have to worry about splitting up the metrics into different weeks, diamondash and graphite will handle this.

https://github.com/praekelt/go-nike-ghr/blob/develop/js_sandbox/lib/go-nike-ghr.js#L532

[imsickofmaps]

@justinvdm I left the code in that makes sure we only fire this once a week per user but then when it fires it fires without the wc addition.

[justinvdm]

@imsickofmaps I'm not sure if it makes sense to have this fire once a week per user. Shouldn't it only increment and fire when a new user is encountered?

[imsickofmaps]

@justinvdm I quote:

This line graph widget will contain total users(identified by MSISDN) and total registrations (identified by MSISDN) per week for the previous 16 weeks.

[justinvdm]

@imsickofmaps I don't think the app needs to worry about this. Each time a metric is published, it is kept with a corresponding timestamp in graphite. Diamondash handles grouping the metrics into different weeks based on the metric timestamps. I could well be missing something, so let me know if that makes sense to you.

[justinvdm]

:+1: