search

praekeltfoundation / jspot

Extracts gettext strings from Javascript files into pot files
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Fix issue 14 #15

Closed JSteunou closed 10 years ago

JSteunou commented 10 years ago

Should fix issue #14

I add a cleaning entry point which call a cleaning identifier argument function.

I could not perform change on the gathered node because falafel return updated source at the end of ast walk and the point of gather is to fetch matched nodes, not to get all source code again.

So I had to clean after gathering and encapsulate the node inside an object to keep the line property along with it. Also I made some little changes so functions always return source code, not node or falafel object or src.

All of that with test.

Ready for review, shoot ;)

justinvdm commented 10 years ago

Hi, thanks for the PR! Also, thanks for going with our code conventions, looks clean :) I was actually busy on this already, but I think your approach is better. Will review.

JSteunou commented 10 years ago

Also, I'm not so fluent in English, so if you want to rewrite some comments / test describe / variable name / ... go for it.

justinvdm commented 10 years ago

@JSteunou Nicely done :) Merged, will do a release once #13 has also been reviewed and merged.

justinvdm commented 10 years ago

Actually, this is a bugfix, deserves its own release, will do that soon.

justinvdm commented 10 years ago

@JSteunou 0.2.1 released with this fix.

JSteunou commented 10 years ago

Nice, ty ;)