[HBS extractor] gettext raises "Unexpected identifier Use" is the key contains double quote (")

praekeltfoundation / jspot

Extracts gettext strings from Javascript files into pot files

BSD 3-Clause "New" or "Revised" License

12 stars 2 forks source link

Closed JSteunou closed 10 years ago

JSteunou commented 10 years ago

I have some keys with html in it and a class="foo" broke the extraction :(

JSteunou commented 10 years ago

I cannot reproduce it by adding some test case. Will work on it tomorrow.

justinvdm commented 10 years ago

Hmm, another edge case in hbs I guess. Thanks for the ticket, will look out for a PR ;)

JSteunou commented 10 years ago

PR & well tested in my project :)

That's now I see how difficult it's to imagine all possible use cases when writing a tiny lib ><

justinvdm commented 10 years ago

PR merged, closing ticket.