search

praekeltfoundation / jspot

Extracts gettext strings from Javascript files into pot files
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Watchout the new po2json release #36

Closed JSteunou closed 9 years ago

JSteunou commented 9 years ago

Which bring support to Jed 1.1 which has a breaking changes for plural support.

see https://github.com/SlexAxton/Jed/issues/36 and https://github.com/mikeedwards/po2json/pull/32

ptica commented 9 years ago

Hi, this is troubling me: I use it via grunt

"grunt-jspot": "^0.1.0",
"grunt-po2json": "git://github.com/rockykitamura/grunt-po2json.git",
"grunt-json": "^0.1.3",

with such package.json and Jed 1.1 I do NOT get any translation, as there seems to be a null entry prepended to every item and Jed just returns the original

if I downgrade to like Jed 0.5.5 the gettext stack works ok. not sure, what should I upgrade to get it working please?

JSteunou commented 9 years ago

You might had post this on grunt-po2json or po2json project but no big deal.

I think it's related to your grunt-po2json task. It should contain 

options: {
  format: 'jed1.x'
}

if you're using Jed 1.1 because of the breaking change from Jed on plural form. This change wasnt follow by a strict semver tag so guys from po2json introduce this option.

Also you dont have to link grunt-po2json through github, it's back on npm since a while now.

justinvdm commented 9 years ago

@JSteunou thanks for replying :)

re the original issue (watching out for newer po2json using Jed 1.1), is there anything in particular you think we need to watch out for? I would imagine jspot would only be affected if po2json's api changed as a result. Tests seem to pass with po2json 0.4.1, maybe we're okay?

JSteunou commented 9 years ago

I think we are. I created this as a reminder but more fright than real harm.

ptica commented 9 years ago

hi! I'm very thankful that I've stumbled upon this message, it is very confusing when a toolchain suddenly stops translating with no error message and nothing written in READMEs anywhere :(

justinvdm commented 9 years ago

@JSteunou Ah I see, thanks :) decided that I may as well turn this into a PR with the newer po2json, will merge when travis is happy.