Tests for ACME things are quite limited

praekeltfoundation / marathon-acme

Automate ACME certificates for Marathon apps served by marathon-lb

MIT License

8 stars 3 forks source link

Tests for ACME things are quite limited #85

Open JayH5 opened 7 years ago

JayH5 commented 7 years ago

We don't have a fake ACME service to test against and txacme's fake client doesn't really do much. It's difficult to run proper tests around ACME things like this, e.g. to test we send the right email address on registration, or respond to ACME challenges at the right path.

JayH5 commented 7 years ago

One thing we could be doing that we're not is using the FakeClientController to at least assert on the number of certificates we're trying to issue.