search

praekeltfoundation / seaworthy

Test harness for Docker container images 🌊 🚢
BSD 3-Clause "New" or "Revised" License
29 stars 4 forks source link

Add a wait_timeout parameter to ContainerBase #21

Closed JayH5 closed 7 years ago

JayH5 commented 7 years ago

10 seconds is not always enough and overriding the whole method is a pain.

codecov[bot] commented 7 years ago

Codecov Report

Merging #21 into develop will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #21      +/-   ##
===========================================
+ Coverage    99.41%   99.42%   +<.01%     
===========================================
  Files           20       20              
  Lines         1547     1558      +11     
  Branches       119      120       +1     
===========================================
+ Hits          1538     1549      +11     
  Misses           7        7              
  Partials         2        2
Impacted Files Coverage Δ
seaworthy/tests-core/test_logs.py 100% <ø> (ø) :arrow_up:
seaworthy/logs.py 100% <100%> (ø) :arrow_up:
seaworthy/containers/provided.py 90.27% <100%> (ø) :arrow_up:
seaworthy/containers/base.py 100% <100%> (ø) :arrow_up:
seaworthy/tests-core/containers/test_base.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10d6a53...518d950. Read the comment docs.

JayH5 commented 7 years ago

:+1: from me on your code.