search

praekeltfoundation / seaworthy

Test harness for Docker container images 🌊 🚢
BSD 3-Clause "New" or "Revised" License
29 stars 4 forks source link

Yet another log stream implementation #36

Closed jerith closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #36 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #36   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           24     24           
  Lines         2248   2259   +11     
  Branches       147    144    -3     
======================================
+ Hits          2248   2259   +11
Impacted Files Coverage Δ
seaworthy/tests-core/containers/test_base.py 100% <100%> (ø) :arrow_up:
seaworthy/logs.py 100% <100%> (ø) :arrow_up:
seaworthy/tests-core/test_logs.py 100% <100%> (ø) :arrow_up:
seaworthy/containers/base.py 100% <100%> (ø) :arrow_up:
seaworthy/_lowlevel.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9da856...3060193. Read the comment docs.

jerith commented 7 years ago

I think I would need a lot of ☕️ to be in the right space to go through the internals of the Docker client to fully understand this...

If only it were just the docker client... I had to wade through requests, urllib3, and a bunch of stdlib http and socket code to get to the bottom of this stuff. At least this implementation is finally reliable and about as clean as we're likely to get without rolling our own docker client library around h11 or something.