search

praekeltfoundation / seaworthy

Test harness for Docker container images 🌊 🚢
BSD 3-Clause "New" or "Revised" License
29 stars 4 forks source link

Optional testtools integration #5

Closed jerith closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #5 into develop will increase coverage by 12.99%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop       #5       +/-   ##
============================================
+ Coverage    62.43%   75.43%   +12.99%     
============================================
  Files            6        8        +2     
  Lines          189      289      +100     
  Branches        22       32       +10     
============================================
+ Hits           118      218      +100     
  Misses          71       71
Impacted Files Coverage Δ
seaworthy/testtools.py 100% <100%> (ø)
seaworthy/tests/test_utils.py 100% <100%> (ø) :arrow_up:
seaworthy/tests-testtools/test_testtools.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a73be26...8778002. Read the comment docs.

jerith commented 7 years ago

Our test deps pull in testtools and pytest, so we're currently not testing that seaworthy doesn't accidentally depend on those things.

It might be worth splitting the tests into core, extra (or testtools, pytest, etc.), and integration sections, with the dependencies of everything except integration tightly controlled to avoid accidental leakage.

jerith commented 7 years ago

Travis was unavailable for the last two commits before merging, but the tests passed locally.