Hook up time range message downloads

praekeltfoundation / vumi-go

BSD 3-Clause "New" or "Revised" License

16 stars 20 forks source link

Hook up time range message downloads #1345

Closed hodgestar closed 9 years ago

hodgestar commented 9 years ago

Ready for review.

hodgestar commented 9 years ago

Okay, maybe ready for review now. ;)

hodgestar commented 9 years ago

I'm not sure how https://github.com/praekelt/vumi-go/pull/1340/files#diff-8b9eacc3cdf12b6761950e2895d5cd66R795 passed in #1340. I don't find the "unique people" in the conversation templates anymore?

justinvdm commented 9 years ago

I'm not sure how https://github.com/praekelt/vumi-go/pull/1340/files#diff-8b9eacc3cdf12b6761950e2895d5cd66R795 passed in #1340. I don't find the "unique people" in the conversation templates anymore?

Hrm, that is weird. I remember changing those tests to match the new way we are displaying the uniques, maybe I'm remembering wrong.

hodgestar commented 9 years ago

Hrm, that is weird. I remember changing those tests to match the new way we are displaying the uniques, maybe I'm remembering wrong.

There is a new test -- it looks like the merging just got confused by the deletion of the old test and the creation of a new test above it.

hodgestar commented 9 years ago

Ready for re-review.

Still need to:

Open the modal if the form is bound.
Restore the old data if the form is bound.

hodgestar commented 9 years ago

Hopefully all done now.

justinvdm commented 9 years ago

Other than the non-input-validation error handling stuff that we discussed over slack and the filenames comment, just a few minor things. Looks good.

justinvdm commented 9 years ago

:+1:! (when travis is happy)

hodgestar commented 9 years ago

Oops. Missed a file in the last commit.