search

praekeltfoundation / vumi-jssandbox-toolkit

Vumi JavaScript Sandbox toolkit.
BSD 3-Clause "New" or "Revised" License
7 stars 8 forks source link

Fix url formatting in http helper and dummy with node v0.11.15 #214

Closed justinvdm closed 9 years ago

justinvdm commented 9 years ago

node v0.11.15's url module handles things a bit differently when parsing or formatting a url with params. The path field in the object returned by url.parse overrides the query field, so we need to unset path in order for the query field to be used as we need it to.

There is a ticket for this, but it seems possible that this behaviour is going to stay: https://github.com/joyent/node/issues/9070

justinvdm commented 9 years ago

Ready for review, I think.

hodgestar commented 9 years ago

:+1:

Tx for fixing this.