search

praekeltfoundation / vumi-wikipedia

Vumi Wikipedia Application
BSD 3-Clause "New" or "Revised" License
8 stars 8 forks source link

Content continuation by SMS #12

Closed jerith closed 12 years ago

jerith commented 12 years ago

We need to be able to send further article content by SMS on receipt of a reply to content already sent.

This would allow access to more of the article content, as well as providing a better user experience and a potential revenue stream for a zero-rated basic service.

jerith commented 12 years ago

This isn't ready to land yet. PR is just to get some interim review feedback.

hodgestar commented 12 years ago

A somewhat higher level observation -- the application now listens on two endpoints for two different sorts of SMSes. The approach taken in core Vumi application workers is somewhat different -- there there is only a single endpoint. Outgoing messages are differentiated by .send_to() which takes a tag to select amongst various message payload options (e.g. transport_name) that are set in worker configuration. Inbound messages are differentiated on other things (e.g. transport_type or special tag). Just noting the difference in approach for consideration.

jerith commented 12 years ago

I'd like to consolidate this a bit more eventually, but there's a tight deadline on this particular branch. Much of this code predates the Vumi infrastructure to do similar things, and there are assumptions that may need to be revisited.

In the medium term, I'd like to refactor a bit and wrap the base worker in a Vumi Go app. (I want to keep a non-Go standalone version around for larger single-purpose installations, though.)

jerith commented 12 years ago

Ready for review.

hodgestar commented 12 years ago

:+1: