praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Separate fake AMQP channel from real AMQP client #1002

Closed jerith closed 8 years ago

jerith commented 8 years ago

We have a few tests that look for fake AQMP things on the channel objects belonging to clients. As part of the work in #1000, AMQP clients will get real channel objects instead fake ones and will have to look at channel._fake_channel to get at the fake stuff.

To make that transition easier, it seems sensible to wrap the current fake channel with a more realistic one and expose the underlying fake on channel._fake_channel.

Review on Reviewable

smn commented 8 years ago

:+1:


Reviewed 8 of 8 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

JayH5 commented 8 years ago

:+1:


Comments from the review on Reviewable.io

JayH5 commented 8 years ago

Reviewed 8 of 8 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from the review on Reviewable.io