search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Add a helper method for publishing status events in http rpc transport #1005

Closed justinvdm closed 8 years ago

justinvdm commented 8 years ago

We need to add a helper method to the base http rpc transport that makes use of the component added in #1004.

rudigiesler commented 8 years ago

Ready for review.

hodgestar commented 8 years ago

Left two comments, but looks good.

hodgestar commented 8 years ago

One other thought -- does add_status belong on the base transport perhaps?

rudigiesler commented 8 years ago

I don't know if it belongs in the base transport, since not all transports need it. Things like the SMPP transport only sends a status on certain events, so it won't have the problem of sending the same status over and over again. It could maybe go in the base transport if we find that other transports need it, but so far it's just the HTTP RPC transport that needs it

rudigiesler commented 8 years ago

Changed the way that the edge detector takes in arguments. Ready for review again.

justinvdm commented 8 years ago

:+1: from me.