search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Add status for dmark transport timeouts #1009

Closed rudigiesler closed 8 years ago

rudigiesler commented 8 years ago

Ready for review.

justinvdm commented 8 years ago

Not too important idea: response times are something well suited to middleware, wondering if there is a way we could have a middleware for this instead? Thoughts?

justinvdm commented 8 years ago

Not too important idea: response times are something well suited to middleware, wondering if there is a way we could have a middleware for this instead? Thoughts?

Actually, nvm, what we are trying to do is way too tied into the requests and responses that only the transport knows about to have a middleware do this.

justinvdm commented 8 years ago

Left a few comments, looks good.

rudigiesler commented 8 years ago

@justinvdm: Addressed your comments. Ready for review again.

justinvdm commented 8 years ago

:+1: