search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Change response time to base transport calling subclass #1011

Closed rudigiesler closed 8 years ago

rudigiesler commented 8 years ago

Currently, the subclass for the http transport needs to call set_request_start and set_request_end in the base function to be able to send status events for long response times. Change this to have the base httprpc transport calculate the times, and if they exceed the configured values, call a function in the subclass transport that has the logic to do the correct thing (for dmark, send the relevant status event).

rudigiesler commented 8 years ago

Ready for review.

justinvdm commented 8 years ago

Left some minor comments, looks good :)

rudigiesler commented 8 years ago

@justinvdm Addressed your comments. Ready for another review.

justinvdm commented 8 years ago

:+1: when travis is happy