search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Use new worker logger #1016

Closed rudigiesler closed 8 years ago

rudigiesler commented 8 years ago

Use the new worker logger for a few transports.

rudigiesler commented 8 years ago

Ready for review.

jerith commented 8 years ago

Some of the updated multiline log calls are probably pep8 violations.

hodgestar commented 8 years ago

Error from Travis:

Traceback (most recent call last):
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/twisted/internet/defer.py", line 1128, in _inlineCallbacks
    result = g.send(result)
  File "/home/travis/build/praekelt/vumi/vumi/transports/smpp/tests/test_protocol.py", line 332, in test_bind_transmitter
    protocol = yield self.get_protocol(bind_type='TX')
  File "/home/travis/build/praekelt/vumi/vumi/transports/smpp/tests/test_protocol.py", line 76, in get_protocol
    dummy_service = DummySmppService(self.clock, self.redis, cfg)
  File "/home/travis/build/praekelt/vumi/vumi/transports/smpp/tests/test_protocol.py", line 28, in __init__
    self, config.delivery_report_processor_config)
  File "/home/travis/build/praekelt/vumi/vumi/transports/smpp/processors/default.py", line 85, in __init__
    self.log = transport.log
exceptions.AttributeError: 'DummySmppService' object has no attribute 'log'
rudigiesler commented 8 years ago

Fixed the pep8 violations. Tests should also be fixed now.

rudigiesler commented 8 years ago

Ready for review again.

hodgestar commented 8 years ago

:+1: once Travis is happy. I restarted the failed test (it looks unrelated, but wasn't 100% sure).