Add support for event exports. - Githubissues

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.

BSD 3-Clause "New" or "Revised" License

420 stars 131 forks source link

Add support for event exports. #1017

Closed hodgestar closed 8 years ago

hodgestar commented 8 years ago

After some discussion the consensus appears to be something along the lines of:

Being able to export events would be good.
Exporting should be provided by a separate event exporting resource (to go with the ones for inbound and outbound)
We should not retrieve events by looking up the events for particular outbound messages, because this results in a Riak index query per outbound message (which is very bad for performance).
This leaves us retrieving events by event timestamp (not the most terrible thing).

hodgestar commented 8 years ago

Ready for review.

Aside: The outbound and inbound message exporting has a lot of tests. I added fewer for the events because all of the range-parsing code being tested is shared between the three implementations.

jerith commented 8 years ago

What's the reason for adding the keys_only param to the existing methods?

hodgestar commented 8 years ago

keys_only option removed. It was there to allow list(page) to return a list of keys, but I've worked around that.

hodgestar commented 8 years ago

Merged in develop to fix test that was fixed in develop.

Ready for re-review.

hodgestar commented 8 years ago

Build failures are only on Twisted 13 and seem unrelated.

hodgestar commented 8 years ago

Ready for re-re-review. :)

jerith commented 8 years ago

:+1: when Travis is finished.