search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Use Vumi codecs for outbound SMPP messages. #1019

Open hodgestar opened 8 years ago

hodgestar commented 8 years ago

We have special support for GSM 03.38 and UCS2 codecs for inbound SMPP messages, but we don't provide these for outbound SMPP messages currently.

hodgestar commented 8 years ago

The inbound SMPP message processor (DeliverShortMessageProcessor) sets up a Vumi codec class at https://github.com/praekelt/vumi/blob/develop/vumi/transports/smpp/processors/default.py#L253 and uses it at https://github.com/praekelt/vumi/blob/develop/vumi/transports/smpp/processors/default.py#L288.

The outbound SMPP message processor (SubmitShortMessageProcessor) should do the equivalent. We will need to replace https://github.com/praekelt/vumi/blob/develop/vumi/transports/smpp/processors/default.py#L510.

We will also need a test that GSM 03.38 works.