search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

adding status message for bad request + tests #1022

Closed codiebeulaine closed 8 years ago

codiebeulaine commented 8 years ago

@justinvdm not quite sure why the test is failing?

hodgestar commented 8 years ago

The failures might be related to treq no longer supporting Python 2.6. I have a PR open for officially removing Python 2.6 support. On 22 Feb 2016 17:42, "codie" notifications@github.com wrote:

@justinvdm https://github.com/justinvdm not quite sure why the test is failing?

— Reply to this email directly or view it on GitHub https://github.com/praekelt/vumi/pull/1022#issuecomment-187236880.

codiebeulaine commented 8 years ago

@hodgestar @justinvdm ready for review :)

codiebeulaine commented 8 years ago

@hodgestar @justinvdm added the good request stuff

hodgestar commented 8 years ago

@codiebeulaine Please no commit messages like cleaning up. ;)

hodgestar commented 8 years ago

Left a couple of comments and questions, but otherwise looks good. :)

codiebeulaine commented 8 years ago

@hodgestar changed some things above, Do I need to change the method above back or can I get a +1 ?

hodgestar commented 8 years ago

:+1: