Cleanup Vumi bridge and add Junebug support

[hodgestar]

Left two small comments, and we need to look at why tests are failing, but otherwise looks good.

[hodgestar]

Given that unrelated middleware tests are failing for all builds except the one pinned to Twisted 13.2, I suspect this indicates more tests broken by Twisted 16.0.

[rudigiesler]

@hodgestar Looking at the middleware tests that are failing, looks like there's a twisted import (to do with ssh), that if it fails, the tests aren't run. So it's very possible that the latest twisted fixed that module import, and that test has been broken for a very long time. (Either way, completed unrelated to this PR).

[hodgestar]

Creating #1029 to deal with the manhole middleware test failures.

[KaitCrawford]

@hodgestar @rudigiesler Please give this another look. I'm not sure the last commit is what you meant hodgestar, I might be misunderstanding how web_path gets used. I also think I should probably be updating the status in more places but I'm struggling to identify where.

[hodgestar]

@KaitCrawford Could you merge develop into this branch so we can check if tests pass?

[hodgestar]

Other than removing the TODO, looks good to me!

[KaitCrawford]

Really? \o/ whoohooo!

[rudigiesler]

Looks good to me too. :+1:

[hodgestar]

Oh, I realized something -- do we want to add status events for inbound messages too? Just "good" if we receive a valid request and "bad" if we receive a broken request?

[hodgestar]

I also remembered that we wanted to only publish acks once we received an ack from Vumi Go (so publish a nack if submitting the message to Vumi Go fails and then publish whatever event Vumi Go gives us).

[hodgestar]

Maybe this means we should also re-think the components a bit. Maybe we want separate components for http-requests-to-vumi-go, http-requests-from-vumi-go and events-from-vumi-go (except with better names)?

[KaitCrawford]

@hodgestar the names are probably still horrible :)

[hodgestar]

Idea for better status component names:

• http-requests-to-vumi-go -> submitted-to-vumi-go
• http-requests-from-vumi-go -> received-from-vumi-go
• events-from-vumi-go -> sent-by-vumi-go

Thoughts?

[KaitCrawford]

@hodgestar please re-review

[KaitCrawford]

@hodgestar updated again

[hodgestar]

Left what I hope are the last two minor comments!

[KaitCrawford]

@hodgestar ready for another round

[hodgestar]

:+1: :cake:

Also, I am honoured to present @KaitCrawford with The Monthly :camel: Trophy for continuing with this PR all the way to the end!

[KaitCrawford]

what is a :camel: trophy and should I be scared?

[hodgestar]

It is a trophy for successfully crossing the desert. :)