search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
421 stars 131 forks source link

Fix manhole middleware tests. #1029

Closed hodgestar closed 8 years ago

hodgestar commented 8 years ago

These tests suddenly run under Travis with Twisted 16.0 (yay!), but are very broken (eep!).

hodgestar commented 8 years ago

This version passes tests locally for me on Twisted 16.0. Will need to see what happens with Twisted 13.2 in Travis.

hodgestar commented 8 years ago

The tests are skipped for Twisted 13.2 on Travis as they always were and now pass on Twisted 16.0. Given that the tests were completely broken (on all Twisted versions before), these feels like it's already a major improvement.

Ready for review.

hodgestar commented 8 years ago

Tests now run & pass for Twisted 13.2 too.

hodgestar commented 8 years ago

@rudigiesler @KaitCrawford Would you mind reviewing?

rudigiesler commented 8 years ago

:+1: