Vumi Bridge transport fails to shut down cleanly if it doesn't start up.

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.

BSD 3-Clause "New" or "Revised" License

421 stars 131 forks source link

Closed hodgestar closed 8 years ago

hodgestar commented 8 years ago

The teardown method needs to not assume that .web_resource is present.

hodgestar commented 8 years ago

Ready for review.

rudigiesler commented 8 years ago

Just the one question from me. Looks good otherwise.

hodgestar commented 8 years ago

The setup_transport method is currently empty and I'm removing it as part of #1036 (sorry, should have mentioned that in a comment straight away).

rudigiesler commented 8 years ago

Ah okay, I see. :+1: