search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
422 stars 131 forks source link

Fix tests for Twisted 16.3. #1049

Closed hodgestar closed 8 years ago

hodgestar commented 8 years ago

Twisted 16.3 changed how HTTPChannels work which broken a bunch of tests:

vumi.transports.mxit.tests.test_mxit.TestMxitTransport.test_get_request_content_when_missing
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/home/travis/build/praekelt/vumi/vumi/transports/mxit/tests/test_mxit.py", line 103, in test_get_request_data
    req = Request(None, True)
  File "/home/travis/env-pypy-4.0.1/site-packages/twisted/web/http.py", line 612, in __init__
    self.transport = self.channel.transport
exceptions.AttributeError: 'NoneType' object has no attribute 'transport'
hodgestar commented 8 years ago

Ready for review.

rudigiesler commented 8 years ago

:+1: