Only use decimal digits in MTN Nigeria XML over TCP transport session IDs.

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.

BSD 3-Clause "New" or "Revised" License

421 stars 131 forks source link

Closed hodgestar closed 8 years ago

hodgestar commented 8 years ago

Currently we use hexadecimal digits, but non-decimal digits are not allowed.

hodgestar commented 8 years ago

Anyone have any opinions on using:

session_id = "".join(random.choice("0123456789") for i in range(SESSION_ID_LENGTH))

as a method for generating a session id?

justinvdm commented 8 years ago

:+1: when travis is happy

hodgestar commented 8 years ago

I've confirmed that all the Travis errors are covered by #1049 and that the tests pass locally, so landing this.