Replace http_request_full internals with treq

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.

BSD 3-Clause "New" or "Revised" License

421 stars 131 forks source link

Replace http_request_full internals with treq #1058

Closed smn closed 7 years ago

KaitCrawford commented 7 years ago

@smn I just changed the order of things a little

smn commented 7 years ago

💥 amazing! Thank you :) :cake: 🍰 :cake: 👍

erikh360 commented 7 years ago

👍

KaitCrawford commented 7 years ago

@JayH5 ^^ this commit removes usage of WebClientContextFactory() from the sandbox and it doesn't appear anywhere else in the repo. I'm not sure if that's enough though?

JayH5 commented 7 years ago

@KaitCrawford I actually read the sandbox.py file.. it says it's deprecated and people should use vxsandbox rather which is what we do for Seed. So I'd say maybe actually just don't touch sandbox.py in this PR.

JayH5 commented 7 years ago

Looks like this is definitely fixed in vxsandbox, even if treq isn't used there: https://github.com/praekelt/vumi-sandbox/blob/develop/vxsandbox/resources/http.py#L23-L41