search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
421 stars 131 forks source link

Fix message sender for new riak client #1064

Closed rudigiesler closed 7 years ago

rudigiesler commented 7 years ago

With the new riak client, we will have to change the way that we do cleanup for tests. We need to create a new manager to do the cleanup, instead of using the existing closed manager.

justinvdm commented 7 years ago

:+1: when travis is happy

Seems unlikely, but do you know whether the change to the new riak client affects our non-test code? I'm guessing it would be the case if anywhere in our code we tried to purge data for a closed manager.

rudigiesler commented 7 years ago

Tests are failing, I'm guessing that new treq doesn't like old twisted

rudigiesler commented 7 years ago

@justinvdm Thanks. I'm assuming that we don't purge data in non-test code, so that it wouldn't be a problem.

jerith commented 7 years ago

Anything that uses a closed manager in non-test-cleanup code should fail its tests with the new behaviour. There might be a bug or two where this happens in code paths we don't test, but that's true of any code using things we might update.

rudigiesler commented 7 years ago

@justinvdm I've fixed the treq problem by pinning it to an older version that still supports twisted 13.2.0. Can you give it another look?

justinvdm commented 7 years ago

👍 !