Improve Python 3 support

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.

BSD 3-Clause "New" or "Revised" License

421 stars 131 forks source link

Improve Python 3 support #1075

Closed alexmuller closed 6 years ago

alexmuller commented 6 years ago

This is probably really boring to review but hopefully it's fairly uncontroversial. Every change here acts identically between between Python 2.7 and Python 3.6.

I've tried to group the changes into logical commits and have added more details in each commit message.

JayH5 commented 6 years ago

LGTM so far.

A couple of minor things:

We should probably test against Python 3.5 as well since that's what's in Debian Jessie/Ubuntu Xenial.
I would probably do from __future__ import print_function where we print.

alexmuller commented 6 years ago

Thanks! Pushed two more commits to address your comments.