Encoding of routing_key when creating Publisher or Consumer

[overnin]

When creating a Publisher or a Consumer, the routing key has to be encoded as string. There is no validation on how this value in encoded which can throw an error when the routing_key is in unicode.

This issue can happen when dynamically modifying the configuration of vumi elements (worker, dispatcher or transport) via RabbitMQ message. Indeed RabbitMQ is encoding all the message key/value in unicode.

Use case: A new worker is dynamically created by a multiworker, the transport_name=xmpp of this new worker is send to the multiworker via RabbitMQ. Then the multiworker is creating the worker and is passing his transport_name. Finally, the worker throw an exception as it is creating his Publisher with the "xmpp" in unicode.

[smn]

@overnin thanks for this.

Dynamically starting workers based on received AMQP messages is something we've looked at doing for a while. Is this something you are already implementing / using? Would love to learn from your work if at all possible.

[overnin]

Yep, there are dynamic stuff that i'd like to share next week:

• a dynamic router (using the Keyword dispatcher)
• a dynamic multiworker. If interested, i can add pull requests for one or both of them.

[hodgestar]

@overnin Any word on this?